fix: renderer: sync buffer resize with frame rate

We need to resize the internal screen buffer after a resize event.
However, we shouldn't do that immediately in the resize handler, as that
can lead to tearing if the terminal keeps sending resize events rapidly.
Instead, we defer the resize to the next render cycle, ensuring that the
buffer is resized in sync with the frame rendering.
This commit is contained in:
Ayman Bagabas 2025-10-30 10:28:21 -04:00
parent b4d105e51c
commit d7c95b8a27
No known key found for this signature in database
GPG key ID: C8D51D2157C919AC

View file

@ -231,6 +231,53 @@ func (s *cursedRenderer) flush() error {
view := s.view
// Figure out the frame size we need.
frameArea := uv.Rect(0, 0, s.width, s.height)
if view.Layer == nil {
// If the component is nil, we should clear the screen buffer.
frameArea.Max.Y = 0
}
if !view.AltScreen {
// We need to resizes the screen based on the frame height and
// terminal width. This is because the frame height can change based on
// the content of the frame. For example, if the frame contains a list
// of items, the height of the frame will be the number of items in the
// list. This is different from the alt screen buffer, which has a
// fixed height and width.
frameHeight := frameArea.Dy()
switch l := view.Layer.(type) {
case interface{ Height() int }:
frameHeight = l.Height()
case interface{ Bounds() uv.Rectangle }:
frameHeight = l.Bounds().Dy()
}
if frameHeight != frameArea.Dy() {
frameArea.Max.Y = frameHeight
}
}
if frameArea != s.buf.Bounds() {
// Resize the screen buffer to match the frame area. This is necessary
// to ensure that the screen buffer is the same size as the frame area
// and to avoid rendering issues when the frame area is smaller than
// the screen buffer.
s.buf.Resize(frameArea.Dx(), frameArea.Dy())
}
// Clear our screen buffer before copying the new frame into it to ensure
// we erase any old content.
if view.Layer != nil {
view.Layer.Draw(s.buf, s.buf.Bounds())
}
// If the frame height is greater than the screen height, we drop the
// lines from the top of the buffer.
if frameHeight := frameArea.Dy(); frameHeight > s.height {
s.buf.Lines = s.buf.Lines[frameHeight-s.height:]
}
// Alt screen mode.
enableAltScreen(s, view.AltScreen)
// Cursor visibility.
@ -397,52 +444,8 @@ func (s *cursedRenderer) flush() error {
// render implements renderer.
func (s *cursedRenderer) render(v View) {
s.mu.Lock()
defer s.mu.Unlock()
frameArea := uv.Rect(0, 0, s.width, s.height)
if v.Layer == nil {
// If the component is nil, we should clear the screen buffer.
frameArea.Max.Y = 0
}
// We need to resizes the screen based on the frame height and
// terminal width. This is because the frame height can change based on
// the content of the frame. For example, if the frame contains a list
// of items, the height of the frame will be the number of items in the
// list. This is different from the alt screen buffer, which has a
// fixed height and width.
frameHeight := frameArea.Dy()
switch l := v.Layer.(type) {
case *uv.StyledString:
frameHeight = l.Height()
case interface{ Bounds() uv.Rectangle }:
frameHeight = l.Bounds().Dy()
}
if frameHeight != frameArea.Dy() {
frameArea.Max.Y = frameHeight
}
// Resize the screen buffer to match the frame area. This is necessary
// to ensure that the screen buffer is the same size as the frame area
// and to avoid rendering issues when the frame area is smaller than
// the screen buffer.
s.buf.Resize(frameArea.Dx(), frameArea.Dy())
// Clear our screen buffer before copying the new frame into it to ensure
// we erase any old content.
s.buf.Clear()
if v.Layer != nil {
v.Layer.Draw(s.buf, s.buf.Bounds())
}
// If the frame height is greater than the screen height, we drop the
// lines from the top of the buffer.
if frameHeight := frameArea.Dy(); frameHeight > s.height {
s.buf.Lines = s.buf.Lines[frameHeight-s.height:]
}
s.view = v
s.mu.Unlock()
}
// hit implements renderer.
@ -521,8 +524,8 @@ func (s *cursedRenderer) resize(w, h int) {
// We need to reset the touched lines buffer to match the new height.
s.buf.Touched = nil
s.scr.Resize(s.width, s.height)
s.width, s.height = w, h
s.scr.Resize(s.width, s.height)
s.mu.Unlock()
}