fix: use CancelIoEx to cancel Windows conInputReader across threads (#1305)

The Windows conInputReader uses `windows.CancelIo` to close the read
loop's input handle. Windows `CancelIo` docs indicate that call is only
appropriate for I/O operations on the same thread as the `CancelIo`
call. Since the read loop is in its own goroutine, it's likely to be on
another thread from the bubbletea Program.

This change adds a call to Windows `CancelIoEx`, which will cancel I/O
operations across threads.

Fixes #1167
This commit is contained in:
Adam Woodbeck 2025-02-04 11:09:49 -05:00 committed by GitHub
parent 22ba68a342
commit c8d6005325
No known key found for this signature in database
GPG key ID: B5690EEEBB952194

View file

@ -57,7 +57,7 @@ func newInputReader(r io.Reader) (cancelreader.CancelReader, error) {
func (r *conInputReader) Cancel() bool {
r.setCanceled()
return windows.CancelIo(r.conin) == nil
return windows.CancelIoEx(r.conin, nil) == nil || windows.CancelIo(r.conin) == nil
}
// Close implements cancelreader.CancelReader.